[PATCH v3 17/18] of: unittest: find overlays[] entry by name instead of index

[frowand . list]

From: Frank Rowand <frank.row...@sony.com>

One accessor of overlays[] was using a hard coded index value to
find the correct array entry instead of searching for the entry
containing the correct name.

Signed-off-by: Frank Rowand <frank.row...@sony.com>
---
 drivers/of/unittest.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 1c2bd8503095..785985bdbfa6 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -2178,7 +2178,7 @@ struct overlay_info {
 OVERLAY_INFO_EXTERN(overlay_bad_phandle);
 OVERLAY_INFO_EXTERN(overlay_bad_symbol);
 
-/* order of entries is hard-coded into users of overlays[] */
+/* entries found by name */
 static struct overlay_info overlays[] = {
        OVERLAY_INFO(overlay_base, -9999),
        OVERLAY_INFO(overlay, 0),
@@ -2201,7 +2201,8 @@ struct overlay_info {
        OVERLAY_INFO(overlay_bad_add_dup_prop, -EINVAL),
        OVERLAY_INFO(overlay_bad_phandle, -EINVAL),
        OVERLAY_INFO(overlay_bad_symbol, -EINVAL),
-       {}
+       /* end marker */
+       {.dtb_begin = NULL, .dtb_end = NULL, .expected_result = 0, .name = NULL}
 };
 
 static struct device_node *overlay_base_root;
@@ -2231,6 +2232,19 @@ void __init unittest_unflatten_overlay_base(void)
        u32 data_size;
        void *new_fdt;
        u32 size;
+       int found = 0;
+       const char *overlay_name = "overlay_base";
+
+       for (info = overlays; info && info->name; info++) {
+               if (!strcmp(overlay_name, info->name)) {
+                       found = 1;
+                       break;
+               }
+       }
+       if (!found) {
+               pr_err("no overlay data for %s\n", overlay_name);
+               return;
+       }
 
        info = &overlays[0];
 
@@ -2278,11 +2292,10 @@ static int __init overlay_data_apply(const char 
*overlay_name, int *overlay_id)
 {
        struct overlay_info *info;
        int found = 0;
-       int k;
        int ret;
        u32 size;
 
-       for (k = 0, info = overlays; info && info->name; info++, k++) {
+       for (info = overlays; info && info->name; info++) {
                if (!strcmp(overlay_name, info->name)) {
                        found = 1;
                        break;
-- 
Frank Rowand <frank.row...@sony.com>