> -----Original Message----- > From: Scott Wood <o...@buserror.net> > Sent: 2018年10月25日 2:37 > To: Andy Tang <andy.t...@nxp.com>; sb...@kernel.org; > mturque...@baylibre.com > Cc: robh...@kernel.org; mark.rutl...@arm.com; > b...@kernel.crashing.org; pau...@samba.org; m...@ellerman.id.au; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH 3/3 v2] clk: qoriq: update clock driver > > On Wed, 2018-10-24 at 10:11 +0800, andy.t...@nxp.com wrote: > > From: Yuantian Tang <andy.t...@nxp.com> > > > > Legacy bindings are deleted. So the legacy support in driver can be > > deleted safely. > > NACK (both this and 2/3). The legacy support is intended to preserve > compatibility, regardless of what the dts files in the current kernel tree do. > If years later we find it's been broken for a while and nobody complained, > then maybe it'll be time to remove it, but why deliberately throw away > compatibility the instant the users have been removed from reference > DTs that might be copied by board vendors, etc? > > Note that even if we didn't care about long-term compatibility at all, > removing the support in the same patchset as the change to the dts files > means that the patches can't go in via separate trees (though if that's still > the intent, you should make it clear who you're asking to take what by > putting them in separate patchsets).
Points are taken. Will update this patch set. Thanks a lot. BR, Andy > > -Scott
