Hi Christophe, On 10/24/18 12:12 PM, LEROY Christophe wrote: > Breno Leitao <lei...@debian.org> a écrit : > >> hi Christophe, >> >> On 10/23/2018 12:38 PM, LEROY Christophe wrote: >>> Breno Leitao <lei...@debian.org> a écrit : >>>> >>>> This patch removes the keyword from the definition part, while keeps >>>> it in >>>> the declaration part. >>> >>> I think checkpatch also says that extern should be avoided in >>> declarations. >> >> Thanks for the review. I tried to look at this complain, but I didn't see >> this behavior on checkpatch.pl from kernel 4.19. I created a commit >> that adds >> a new extern prototype and checked the patch. Take a look: > > Use option --strict with checkpatch.pl
Thanks. I fixed this patch and resent a v2 with this fix. Michael, If you happen to accept this series, please ignore this patch (3/9) and use a v2 as its replacement: https://patchwork.ozlabs.org/patch/991444/