On Mon, 5 Nov 2018 at 14:18, Michael Ellerman <m...@ellerman.id.au> wrote: > > I considered putting these behind a cc-option test. If someone has an > > opinion on that I'm happy to change.
> > -CFLAGS-$(CONFIG_PPC32) := -ffixed-r2 $(MULTIPLEWORD) > > +ifndef CONFIG_CC_IS_CLANG > > +#CFLAGS-$(CONFIG_PPC32) := -ffixed-r2 $(MULTIPLEWORD) > > +endif > > I think using cc-option with a comment would be nicer, you could avoid > the ifdef and it would also future-proof it against the option either > appearing in a future clang or disappearing in a future gcc. Thanks Nick and Michael. I agree, I'll re-spin using cc-option. Cheers, Joel