Hi gregkh, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [cannot apply to v4.20-rc5 next-20181205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/gregkh-linuxfoundation-org/Patch-powerpc-function_graph-Simplify-with-function_graph_enter-has-been-added-to-the-4-19-stable-tree/20181204-171923 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc All errors (new ones prefixed by >>): arch/powerpc/kernel/trace/ftrace.c: In function 'prepare_ftrace_return': >> arch/powerpc/kernel/trace/ftrace.c:963:7: error: implicit declaration of >> function 'function_graph_enter'; did you mean 'ftrace_graph_entry'? >> [-Werror=implicit-function-declaration] if (!function_graph_enter(parent, ip, 0, NULL)) ^~~~~~~~~~~~~~~~~~~~ ftrace_graph_entry cc1: all warnings being treated as errors vim +963 arch/powerpc/kernel/trace/ftrace.c 946 947 /* 948 * Hook the return address and push it in the stack of return addrs 949 * in current thread info. Return the address we want to divert to. 950 */ 951 unsigned long prepare_ftrace_return(unsigned long parent, unsigned long ip) 952 { 953 unsigned long return_hooker; 954 955 if (unlikely(ftrace_graph_is_dead())) 956 goto out; 957 958 if (unlikely(atomic_read(¤t->tracing_graph_pause))) 959 goto out; 960 961 return_hooker = ppc_function_entry(return_to_handler); 962 > 963 if (!function_graph_enter(parent, ip, 0, NULL)) 964 parent = return_hooker; 965 out: 966 return parent; 967 } 968 #endif /* CONFIG_FUNCTION_GRAPH_TRACER */ 969 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
