Le 27/02/2019 à 05:57, Alastair D'Silva a écrit :
From: Alastair D'Silva <alast...@d-silva.org>

No need for a return value in read_pasid as it only returns 0.

Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
Reviewed-by: Greg Kurz <gr...@kaod.org>
---

Thanks!
Acked-by: Frederic Barrat <fbar...@linux.ibm.com>


  drivers/misc/ocxl/config.c | 9 ++-------
  1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
index 0ee7856b033d..026ac2ac4f9c 100644
--- a/drivers/misc/ocxl/config.c
+++ b/drivers/misc/ocxl/config.c
@@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 
afu_idx)
        return 0;
  }
-static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
+static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn)
  {
        u16 val;
        int pos;
@@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct 
ocxl_fn_config *fn)
  out:
        dev_dbg(&dev->dev, "PASID capability:\n");
        dev_dbg(&dev->dev, "  Max PASID log = %d\n", fn->max_pasid_log);
-       return 0;
  }
static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn)
@@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct 
ocxl_fn_config *fn)
  {
        int rc;
- rc = read_pasid(dev, fn);
-       if (rc) {
-               dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc);
-               return -ENODEV;
-       }
+       read_pasid(dev, fn);
rc = read_dvsec_tl(dev, fn);
        if (rc) {


Reply via email to