When allocating the slot structure we store a pointer to the associated
device_node. We really should be incrementing the reference count, so
add an of_node_get() during slot alloc and an of_node_put() during slot
dealloc.

Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>
---
 drivers/pci/hotplug/rpaphp_slot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/rpaphp_slot.c 
b/drivers/pci/hotplug/rpaphp_slot.c
index 5282aa3e33c5..93b4a945c55d 100644
--- a/drivers/pci/hotplug/rpaphp_slot.c
+++ b/drivers/pci/hotplug/rpaphp_slot.c
@@ -21,6 +21,7 @@
 /* free up the memory used by a slot */
 void dealloc_slot_struct(struct slot *slot)
 {
+       of_node_put(slot->dn);
        kfree(slot->name);
        kfree(slot);
 }
@@ -36,7 +37,7 @@ struct slot *alloc_slot_struct(struct device_node *dn,
        slot->name = kstrdup(drc_name, GFP_KERNEL);
        if (!slot->name)
                goto error_slot;
-       slot->dn = dn;
+       slot->dn = of_node_get(dn);
        slot->index = drc_index;
        slot->power_domain = power_domain;
        slot->hotplug_slot.ops = &rpaphp_hotplug_slot_ops;
-- 
2.12.3

Reply via email to