On Thu, 2019-03-14 at 04:27:27 UTC, Andrew Donnellan wrote: > sparse complains a lot about opal-call.c: > > arch/powerpc/platforms/powernv/opal-call.c:128:1: warning: symbol > 'opal_invalid_call' was not declared. Should it be static? > arch/powerpc/platforms/powernv/opal-call.c:129:1: warning: symbol > 'opal_console_write' was not declared. Should it be static? > arch/powerpc/platforms/powernv/opal-call.c:130:1: warning: symbol > 'opal_console_read' was not declared. Should it be static? > > Those symbols are forward declared in opal.h, but we can't include that > because the function signatures in opal.h are different. So instead, just > add an extra forward declaration to the OPAL_CALL macro to shut sparse up. > > Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/2f9196b67237f1e59f2753b2968f8ad6 cheers