Re: [PATCH] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

[Christoph Hellwig]

On Wed, May 15, 2019 at 02:09:42PM +0200, Mathieu Malaterre wrote:
> In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9
> option") the following piece of code was added:
> 
>    smp_call_function((smp_call_func_t)set_dawr, &null_brk, 0);
> 
> Since GCC 8 this trigger the following warning about incompatible
> function types:

And the warning is there for a reason, and should not be hidden
behind a cast.  This should instead be fixed by something like this:

diff --git a/arch/powerpc/kernel/hw_breakpoint.c 
b/arch/powerpc/kernel/hw_breakpoint.c
index da307dd93ee3..a26b67a1be83 100644
--- a/arch/powerpc/kernel/hw_breakpoint.c
+++ b/arch/powerpc/kernel/hw_breakpoint.c
@@ -384,6 +384,12 @@ void hw_breakpoint_pmu_read(struct perf_event *bp)
 bool dawr_force_enable;
 EXPORT_SYMBOL_GPL(dawr_force_enable);
 
+
+static void set_dawr_cb(void *info)
+{
+       set_dawr(info);
+}
+
 static ssize_t dawr_write_file_bool(struct file *file,
                                    const char __user *user_buf,
                                    size_t count, loff_t *ppos)
@@ -403,7 +409,7 @@ static ssize_t dawr_write_file_bool(struct file *file,
 
        /* If we are clearing, make sure all CPUs have the DAWR cleared */
        if (!dawr_force_enable)
-               smp_call_function((smp_call_func_t)set_dawr, &null_brk, 0);
+               smp_call_function(set_dawr_cb, &null_brk, 0);
 
        return rc;
 }