On 8/6/19 5:25 AM, Michael Ellerman wrote:
Thomas Falcon <[email protected]> writes:
Reported ethtool link settings for the ibmveth driver are currently
hardcoded and no longer reflect the actual capabilities of supported
hardware. There is no interface designed for retrieving this information
from device firmware nor is there any way to update current settings
to reflect observed or expected link speeds.
To avoid confusion, initially define speed and duplex as unknown and
Doesn't that risk break existing setups?
You're right, sorry for missing that.
allow the user to alter these settings to match the expected
capabilities of underlying hardware if needed. This update would allow
the use of configurations that rely on certain link speed settings,
such as LACP. This patch is based on the implementation in virtio_net.
Wouldn't it be safer to keep the current values as the default, and then
also allow them to be overridden by a motivated user.
That is a good compromise. I will resend an updated version soon with
that change.
Thanks!
cheers
