On Wed, Sep 4, 2019 at 9:51 PM Michael Ellerman <m...@ellerman.id.au> wrote: > > Hari Bathini <hbath...@linux.ibm.com> writes: > > With FADump support now available on both pseries and OPAL platforms, > > update FADump documentation with these details. > > > > Signed-off-by: Hari Bathini <hbath...@linux.ibm.com> > > --- > > Documentation/powerpc/firmware-assisted-dump.rst | 104 > > +++++++++++++--------- > > 1 file changed, 63 insertions(+), 41 deletions(-) > > > > diff --git a/Documentation/powerpc/firmware-assisted-dump.rst > > b/Documentation/powerpc/firmware-assisted-dump.rst > > index d912755..2c3342c 100644 > > --- a/Documentation/powerpc/firmware-assisted-dump.rst > > +++ b/Documentation/powerpc/firmware-assisted-dump.rst > > @@ -72,7 +72,8 @@ as follows: > > normal. > > > > - The freshly booted kernel will notice that there is a new > > - node (ibm,dump-kernel) in the device tree, indicating that > > + node (ibm,dump-kernel on PSeries or ibm,opal/dump/mpipl-boot > > + on OPAL platform) in the device tree, indicating that > > there is crash data available from a previous boot. During > > the early boot OS will reserve rest of the memory above > > boot memory size effectively booting with restricted memory > > @@ -96,7 +97,9 @@ as follows: > > > > Please note that the firmware-assisted dump feature > > is only available on Power6 and above systems with recent > > -firmware versions. > > Notice how "recent" has bit rotted. > > > +firmware versions on PSeries (PowerVM) platform and Power9 > > +and above systems with recent firmware versions on PowerNV > > +(OPAL) platform. > > Can we say something more helpful here, ie. "recent" is not very useful. > AFAIK it's actually wrong, there isn't a released firmware with the > support yet at all, right? > > Given all the relevant firmware is open source can't we at least point > to a commit or release tag or something? > > cheers
Even if we can quote a git sha it's not terrible useful or user friendly. We already gate the feature behind DT nodes / properties existing, so why not just say "fadump requires XYZ firmware feature, as indicated by <ABC> device-tree property."
