On Fri, 2019-11-01 at 17:18 +0100, Christophe Leroy wrote: > > Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit : > > Some drivers, e.g. ucc_uart, need definitions from cpm.h. In order to > > allow building those drivers for non-ppc based SOCs, move the header > > to include/soc/fsl. For now, leave a trivial wrapper at the old > > location so drivers can be updated one by one. > > I'm not sure that's the correct way to go. > > As far as I know, CPM is specific to powerpc (or maybe common to some > motorola 68000). So only powerpc specific drivers should need it. > > If cpm.h includes items that are needed for QE, those items should go in > another .h > > Of course, it doesn't mean we can't move cpm.h in include/soc/fsl, but > anyway only platforms having CPM1 or CPM2 should include it.
QE is basically CPM3 so it's not surprising that cpm.h would be needed. I wonder how much less unnecessary code duplication there would have been if marketing hadn't decided to change the name. -Scott