> -----Original Message----- > From: Rasmus Villemoes <li...@rasmusvillemoes.dk> > Sent: Thursday, November 28, 2019 8:56 AM > To: Qiang Zhao <qiang.z...@nxp.com>; Leo Li <leoyang...@nxp.com>; > Christophe Leroy <christophe.le...@c-s.fr> > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; > linux-ker...@vger.kernel.org; Scott Wood <o...@buserror.net>; Timur Tabi > <ti...@kernel.org>; Rasmus Villemoes <li...@rasmusvillemoes.dk>; > net...@vger.kernel.org > Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of > IS_ERR_VALUE() Hi David, Would you help to review patch 44-47 in the series? If it is fine with you, I can take these 4 patches with the whole series though soc tree to enable the QE drivers on ARM and PPC64 with your ACK. Thanks, Leo > > When building this on a 64-bit platform gcc rightly warns that the error > checking is broken (-ENOMEM stored in an u32 does not compare greater > than (unsigned long)-MAX_ERRNO). Instead, now that > qe_muram_alloc() returns s32, use that type to store the return value and > use standard kernel style "ret < 0". > > Reviewed-by: Timur Tabi <ti...@kernel.org> > Signed-off-by: Rasmus Villemoes <li...@rasmusvillemoes.dk>
- [PATCH v6 36/49] soc: fsl: qe: make cpm_muram_free() retu... Rasmus Villemoes
- [PATCH v6 37/49] soc: fsl: qe: make cpm_muram_free() igno... Rasmus Villemoes
- [PATCH v6 38/49] soc: fsl: qe: drop broken lazy call of c... Rasmus Villemoes
- [PATCH v6 39/49] soc: fsl: qe: refactor cpm_muram_alloc_c... Rasmus Villemoes
- [PATCH v6 40/49] soc: fsl: qe: avoid IS_ERR_VALUE in ucc_... Rasmus Villemoes
- [PATCH v6 41/49] soc: fsl: qe: drop use of IS_ERR_VALUE i... Rasmus Villemoes
- [PATCH v6 42/49] soc: fsl: qe: drop pointless check in qe... Rasmus Villemoes
- [PATCH v6 43/49] soc: fsl: qe: avoid IS_ERR_VALUE in ucc_... Rasmus Villemoes
- [PATCH v6 45/49] net/wan/fsl_ucc_hdlc: fix reading of __b... Rasmus Villemoes
- [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ER... Rasmus Villemoes
- RE: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use... Leo Li
- Re: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid... David Miller
- [PATCH v6 48/49] soc: fsl: qe: remove unused #include of ... Rasmus Villemoes
- [PATCH v6 46/49] net/wan/fsl_ucc_hdlc: reject muram offse... Rasmus Villemoes
- [PATCH v6 49/49] soc: fsl: qe: remove PPC32 dependency fr... Rasmus Villemoes
- [PATCH v6 47/49] net: ethernet: freescale: make UCC_GETH ... Rasmus Villemoes
- Re: [PATCH v6 00/49] QUICC Engine support on ARM, ARM64, ... Timur Tabi
- Re: [PATCH v6 00/49] QUICC Engine support on ARM, AR... Rasmus Villemoes
- Re: [PATCH v6 00/49] QUICC Engine support on ARM, ARM64, ... Li Yang