On Thursday 17 April 2008 17:10, Matt Sealey wrote: > Juergen Beisert wrote: > > Hi, > > + /* the fifo starts right after psc ends */ > > + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ > > Wouldn't > > priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(struct > mpc52xx_psc)); > > Be a little less obtuse use of C?
"priv->psc" is of type "struct mpc52xx_ac97_priv*". If I add 0x58 to it, wouldn't I add 0x58 times the size of "struct mpc52xx_ac97_priv"? Juergen -- Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Vertretung Sued/Muenchen, Germany Phone: +49-8766-939 228 | Fax: +49-5121-206917-9 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev