Hi Timur, On Wed, 15 Jan 2020 07:25:45 -0600 Timur Tabi <ti...@kernel.org> wrote: > > On 1/14/20 12:31 AM, Stephen Rothwell wrote: > > +/** > > + * ev_byte_channel_send - send characters to a byte stream > > + * @handle: byte stream handle > > + * @count: (input) num of chars to send, (output) num chars sent > > + * @bp: pointer to chars to send > > + * > > + * Returns 0 for success, or an error code. > > + */ > > +static unsigned int ev_byte_channel_send(unsigned int handle, > > + unsigned int *count, const char *bp) > > Well, now you've moved this into the .c file and it is no longer > available to other callers. Anything wrong with keeping it in the .h file?
There are currently no other callers - are there likely to be in the future? Even if there are, is it time critical enough that it needs to be inlined everywhere? -- Cheers, Stephen Rothwell
pgpWNHPvSOiXD.pgp
Description: OpenPGP digital signature