On Mon, Apr 21, 2008 at 8:49 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > Should this really be a arch_initcall()? Would it be better for > > > platforms needing it to call it explicitly from one of the platform's > > > machine_arch_initcall()? Otherwise it gets called for all platforms > > > in a multiplatform kernel. > > > > Ok, I'll place it into qe_reset(). > > Ugh, no, I can't. qe_reset() is called too early. And I don't like > having every QE board file to call this through machine_arch_initcall... > Hmm, what to do.. well, is this thaat bad to call this for every > platform?..
Its not great. It has a boot time impact for every platform compiled into the kernel. The problem gets worse every time another block of code uses this method. Personally I prefer platform code calling it explicitly. Making it an of_platform device would also eliminate that problem, but you'd need a method to synchronize the driver with its users. I'm not going to raise a big stink about it, but the issue should not be ignored. Cheers, g. > > > > -- > Anton Vorontsov > email: [EMAIL PROTECTED] > irc://irc.freenode.net/bd2 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
