Nicholas Piggin's on February 28, 2020 11:47 am: > Jordan Niethe's on February 27, 2020 10:58 am: >> On Wed, Feb 26, 2020 at 6:18 PM Nicholas Piggin <npig...@gmail.com> wrote: >> + >> +#define DEREF_PPC_INST_PTR(ptr) \ >> +({ \ >> + ppc_inst __inst; \ >> + __inst.w = *(unsigned int *)(ptr); \ >> + if (PPC_INST_IS_PREFIXED(__inst)) \ >> + __inst.p = *(ppc_prefixed_inst *)(ptr); \ >> + __inst; \ >> +}) > > I'd go an inline with shorter lowercase names. ppc_inst_read(&inst);
Probably inst = ppc_inst_read(mem), rather. Thanks, Nick