Oliver O'Halloran's on March 6, 2020 12:42 pm: > On Fri, Feb 28, 2020 at 2:09 PM Nicholas Piggin <npig...@gmail.com> wrote: >> >> These calls can be used by Linux to annotate BUG addresses with symbols, >> look up symbol addresses in xmon, etc. >> >> This is preferable over having Linux parse the OPAL symbol map itself, >> because OPAL's parsing code already exists for its own symbol printing, >> and it can support other code regions than the skiboot symbols, e.g., >> the wake-up code in the HOMER (where CPUs have been seen to get stuck). >> >> Signed-off-by: Nicholas Piggin <npig...@gmail.com> >> --- >> core/opal.c | 2 + >> core/utils.c | 92 +++++++++++++++++++++++-- >> doc/opal-api/opal-get-symbol-181.rst | 42 +++++++++++ >> doc/opal-api/opal-lookup-symbol-182.rst | 35 ++++++++++ >> include/opal-api.h | 4 +- >> 5 files changed, 168 insertions(+), 7 deletions(-) >> create mode 100644 doc/opal-api/opal-get-symbol-181.rst >> create mode 100644 doc/opal-api/opal-lookup-symbol-182.rst >> >> diff --git a/core/opal.c b/core/opal.c >> index d6ff6027b..d9fc4fe05 100644 >> --- a/core/opal.c >> +++ b/core/opal.c >> @@ -142,6 +142,8 @@ int64_t opal_entry_check(struct stack_frame *eframe) >> case OPAL_CEC_REBOOT: >> case OPAL_CEC_REBOOT2: >> case OPAL_SIGNAL_SYSTEM_RESET: >> + case OPAL_GET_SYMBOL: >> + case OPAL_LOOKUP_SYMBOL: > > These names are still awful :|
Ah yeah sorry I said I'd change them didn't I? Anyway don't merge before the kernel is on board with the idea. Thanks, Nick
