On Mon, Apr 28, 2008 at 7:50 PM, Sean MacLennan <[EMAIL PROTECTED]> wrote:
> diff --git a/arch/powerpc/boot/dts/warp.dts b/arch/powerpc/boot/dts/warp.dts
> index b04a52e..3e95e99 100644
You still need to have *some* kind of change log and a signed-off-by
line in this patch. :-)
There is one minor change that needs to be added below; otherwise:
Acked-by: Grant Likely <[EMAIL PROTECTED]>
(You can add my acked-by line to the next version of this patch if
you're only changing the thing I comment on).
Josh, when he respins it I think the dts changes are ready to be picked up.
> @@ -186,18 +179,45 @@
> GPIO1: [EMAIL PROTECTED] {
> compatible = "ibm,gpio-440ep";
> reg = <ef600c00 48>;
> + #gpio-cells = <2>;
> + gpio-controller;
> +
> + [EMAIL PROTECTED] {
>
> + compatible = "linux,gpio-led";
> + linux,name = ":green:";
> + gpios = <&GPIO1 31>;
Since #gpio-cells is '2'; the gpios property needs to reflect that.
It should be:
gpios = <&GPIO1 31 0>;
The second cell the GPIO controller would use for flags (inverted,
open-drain, etc).
> + };
> +
> + [EMAIL PROTECTED] {
> + compatible = "linux,gpio-led";
> + linux,name = ":red:";
> + gpios = <&GPIO1 30>;
ditto
> + };
>
>
> };
>
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
