Re: [PATCH v6 10/28] powerpc: Introduce functions for instruction equality

[Jordan Niethe]

On Wed, Apr 29, 2020 at 11:59 AM Alistair Popple <alist...@popple.id.au> wrote:
>
> There seems to be a minor typo which breaks compilation when
> CONFIG_MPROFILE_KERNEL is not enabled. See the fix below.
>
> ---
>  arch/powerpc/kernel/trace/ftrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/trace/ftrace.c b/arch/powerpc/kernel/trace/
> ftrace.c
> index a6064e1977ca..0ad2c9d4ab49 100644
> --- a/arch/powerpc/kernel/trace/ftrace.c
> +++ b/arch/powerpc/kernel/trace/ftrace.c
> @@ -499,7 +499,7 @@ expected_nop_sequence(void *ip, struct ppc_inst op0,
> struct ppc_inst op1)
>          * The load offset is different depending on the ABI. For simplicity
>          * just mask it out when doing the compare.
>          */
> -       if ((!ppc_inst_equal(op0), ppc_inst(0x48000008)) || 
> (ppc_inst_val(op1) &
> 0xffff0000) != 0xe8410000)
> +       if ((!ppc_inst_equal(op0, ppc_inst(0x48000008))) || 
> (ppc_inst_val(op1) &
> 0xffff0000) != 0xe8410000)
>                 return 0;
>         return 1;
>  }
Thank you.
> --
> 2.20.1
>
>
>
>