On Thu, 2020-05-07 at 22:30 +0100, Darren Stevens wrote: > > +/include/ "p5040si-pre.dtsi" > + > +/ { > + model = "varisys,CYRUS5040"; > + compatible = "varisys,CYRUS";
Is this board 100% compatible with the Cyrus P5020 board, down to every last quirk, except for the SoC plugged into it? If not, they shouldn't have the same compatible. If they are, then couldn't everything in this file but the SoC include be moved to a dtsi shared with cyrus_p5020.dts? > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&mpic>; > + > + aliases{ > + ethernet0 = &enet4; > + ethernet1 = &enet10; > + }; Space after "aliases" -Scott