On 06/11, Madhavan Srinivasan wrote: > > > On 6/10/20 8:37 PM, Oleg Nesterov wrote: > >Hi, > > > >looks like this patch was forgotten. > > yep, I missed this. But mpe did have comments for the patch. > > https://lkml.org/lkml/2019/9/19/107
Yes, and I thought that I have replied... apparently not, sorry! So let me repeat, I am fine either way, I do not understand this ppc-specific code and I can't really test this change. Let me quote that email from Michael: > We could do it like below. I'm 50/50 though on whether it's worth it, or > if we should just go with the big ifdef like in your patch. up to you ;) Hmm. And yes, > >>This is not consistent and this breaks > >>http://sourceware.org/systemtap/wiki/utrace/tests/user-regs-peekpoke this is 404. Jan, could correct the link above? Oleg.