I'll fix it. > -----Original Message----- > From: Benjamin Herrenschmidt [mailto:[EMAIL PROTECTED] > Sent: Monday, May 05, 2008 9:02 PM > To: Stephen Rothwell > Cc: Stephen Neuendorffer; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linuxppc- > [EMAIL PROTECTED] > Subject: Re: [PATCH 1/4] [v4][POWERPC] refactor dcr code > > > On Tue, 2008-05-06 at 13:40 +1000, Stephen Rothwell wrote: > > Since find_dcr_parent has done a of_node_get on its return value, you > > leak a reference to dp here i.e. you need an of_node_put(dp) before > > you return. > > He inherited that bug from other dcr.c functions I wrote, my fault. > > Stephen (N. not R.), would you mind fixing them while at it or do you > want me to cook up a patch ? > > Cheers, > Ben. > >
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
