Excerpts from Pratik Rajesh Sampat's message of July 18, 2020 4:53 am:
> POWER9 onwards the support for the registers HID1, HID4, HID5 has been
> receded.
> Although mfspr on the above registers worked in Power9, In Power10
> simulator is unrecognized. Moving their assignment under the
> check for machines lower than Power9
> 
> Signed-off-by: Pratik Rajesh Sampat <psam...@linux.ibm.com>
> Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>

Reviewed-by: Nicholas Piggin <npig...@gmail.com>

> ---
>  arch/powerpc/platforms/powernv/idle.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/idle.c 
> b/arch/powerpc/platforms/powernv/idle.c
> index d439e11af101..d24d6671f3e8 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -73,9 +73,6 @@ static int pnv_save_sprs_for_deep_states(void)
>        */
>       uint64_t lpcr_val       = mfspr(SPRN_LPCR);
>       uint64_t hid0_val       = mfspr(SPRN_HID0);
> -     uint64_t hid1_val       = mfspr(SPRN_HID1);
> -     uint64_t hid4_val       = mfspr(SPRN_HID4);
> -     uint64_t hid5_val       = mfspr(SPRN_HID5);
>       uint64_t hmeer_val      = mfspr(SPRN_HMEER);
>       uint64_t msr_val = MSR_IDLE;
>       uint64_t psscr_val = pnv_deepest_stop_psscr_val;
> @@ -117,6 +114,9 @@ static int pnv_save_sprs_for_deep_states(void)
>  
>                       /* Only p8 needs to set extra HID regiters */
>                       if (!pvr_version_is(PVR_POWER9)) {
> +                             uint64_t hid1_val = mfspr(SPRN_HID1);
> +                             uint64_t hid4_val = mfspr(SPRN_HID4);
> +                             uint64_t hid5_val = mfspr(SPRN_HID5);
>  
>                               rc = opal_slw_set_reg(pir, SPRN_HID1, hid1_val);
>                               if (rc != 0)
> -- 
> 2.25.4
> 
> 

Reply via email to