* Jordan Niethe <jniet...@gmail.com> [2020-07-20 17:47:27]:
> On Tue, Jul 14, 2020 at 2:44 PM Srikar Dronamraju
> <sri...@linux.vnet.ibm.com> wrote:
> >
> > Enable small core scheduling as soon as we detect that we are in a
> > system that supports thread group. Doing so would avoid a redundant
> > check.
> >
> > Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
> > Cc: Michael Ellerman <micha...@au1.ibm.com>
> > Cc: Nick Piggin <npig...@au1.ibm.com>
> > Cc: Oliver OHalloran <olive...@au1.ibm.com>
> > Cc: Nathan Lynch <nath...@linux.ibm.com>
> > Cc: Michael Neuling <mi...@linux.ibm.com>
> > Cc: Anton Blanchard <an...@au1.ibm.com>
> > Cc: Gautham R Shenoy <e...@linux.vnet.ibm.com>
> > Cc: Vaidyanathan Srinivasan <sva...@linux.ibm.com>
> > Signed-off-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com>
> > ---
> > arch/powerpc/kernel/smp.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> > index 24529f6134aa..7d430fc536cc 100644
> > --- a/arch/powerpc/kernel/smp.c
> > +++ b/arch/powerpc/kernel/smp.c
> > @@ -892,6 +892,12 @@ static int init_big_cores(void)
> > }
> >
> > has_big_cores = true;
> > +
> > +#ifdef CONFIG_SCHED_SMT
> > + pr_info("Big cores detected. Using small core scheduling\n");
> Why change the wording from "Big cores detected but using small core
> scheduling\n"?
> > + powerpc_topology[0].mask = smallcore_smt_mask;
> > +#endif
> > +
To me, "but" in the message sounded as if we detected Big cores *but* we want
to continue using smallcore scheduling. However the code was always meaning
to say, "Since we detected big core, i.e thread grouping within a core, System
would
benefit by using small core scheduling".
If you think, "but" was adding more info and not misleading, then I can add it
back.
> > return 0;
> > }
> >
--
Thanks and Regards
Srikar Dronamraju
