Hi Nathan, Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v5.11-rc3 next-20210115] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nathan-Lynch/powerpc-rtas-miscellaneous-cleanups-user-region-allocation/20210115-113045 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/656368735841abab983fa593b2ddae52a6273a71 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nathan-Lynch/powerpc-rtas-miscellaneous-cleanups-user-region-allocation/20210115-113045 git checkout 656368735841abab983fa593b2ddae52a6273a71 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): arch/powerpc/kernel/rtas.c: In function 'in_rmo_buf': >> arch/powerpc/kernel/rtas.c:990:26: error: 'RTAS_RMOBUF_MAX' undeclared >> (first use in this function) 990 | base < (rtas_rmo_buf + RTAS_RMOBUF_MAX) && | ^~~~~~~~~~~~~~~ arch/powerpc/kernel/rtas.c:990:26: note: each undeclared identifier is reported only once for each function it appears in arch/powerpc/kernel/rtas.c:994:1: error: control reaches end of non-void function [-Werror=return-type] 994 | } | ^ cc1: some warnings being treated as errors vim +/RTAS_RMOBUF_MAX +990 arch/powerpc/kernel/rtas.c bd59380c5ba4147d Andrew Donnellan 2020-08-20 986 bd59380c5ba4147d Andrew Donnellan 2020-08-20 987 static bool in_rmo_buf(u32 base, u32 end) bd59380c5ba4147d Andrew Donnellan 2020-08-20 988 { bd59380c5ba4147d Andrew Donnellan 2020-08-20 989 return base >= rtas_rmo_buf && bd59380c5ba4147d Andrew Donnellan 2020-08-20 @990 base < (rtas_rmo_buf + RTAS_RMOBUF_MAX) && bd59380c5ba4147d Andrew Donnellan 2020-08-20 991 base <= end && bd59380c5ba4147d Andrew Donnellan 2020-08-20 992 end >= rtas_rmo_buf && bd59380c5ba4147d Andrew Donnellan 2020-08-20 993 end < (rtas_rmo_buf + RTAS_RMOBUF_MAX); bd59380c5ba4147d Andrew Donnellan 2020-08-20 994 } bd59380c5ba4147d Andrew Donnellan 2020-08-20 995 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
