On Fri, 2008-05-23 at 08:02 -0500, Kumar Gala wrote: > On May 23, 2008, at 7:59 AM, Anton Vorontsov wrote: > > > On Fri, May 23, 2008 at 04:32:46PM +0800, Jason Jin wrote: > >> This MSI driver can be used on 83xx/85xx/86xx board. > >> In this driver, virtual interrupt host and chip were > >> setup. There are 256 MSI interrupts in this host, Every 32 > >> MSI interrupts cascaded to one IPIC/MPIC interrupt. > >> The chip was treated as edge sensitive and some necessary > >> functions were setup for this chip. > >> > >> Before using the MSI interrupt, PCI/PCIE device need to > >> ask for a MSI interrupt in the 256 MSI interrupts. A 256bit > >> bitmap show which MSI interrupt was used, reserve bit in > >> the bitmap can be used to force the device use some designate > >> MSI interrupt in the 256 MSI interrupts. Sometimes this is useful > >> for testing the all the MSI interrupts. The msi-available-ranges > >> property in the dts file was used for this purpose. > >> > >> Signed-off-by: Jason Jin <[EMAIL PROTECTED]> > >> --- > > > > Hello Jason, > > > > Few comments below. > > Jason, I'll apply this version. I expect some clean up based on Anton > and Stephen's comments.
Version 4 or 5 of this patch had my ACK for the MSI bits FWIW. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
