Excerpts from Christophe Leroy's message of March 16, 2021 12:07 am: > > > Le 15/03/2021 à 04:17, Nicholas Piggin a écrit : >> With non-volatile registers saved on interrupt, bad_page_fault >> can now be called by do_page_fault. >> >> Signed-off-by: Nicholas Piggin <npig...@gmail.com> >> --- >> arch/powerpc/kernel/exceptions-64e.S | 6 ------ >> arch/powerpc/mm/fault.c | 5 +---- >> 2 files changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/arch/powerpc/kernel/exceptions-64e.S >> b/arch/powerpc/kernel/exceptions-64e.S >> index a059ab3542c2..b08c84e0fa56 100644 >> --- a/arch/powerpc/kernel/exceptions-64e.S >> +++ b/arch/powerpc/kernel/exceptions-64e.S >> @@ -937,12 +937,6 @@ storage_fault_common: >> ld r14,PACA_EXGEN+EX_R14(r13) >> ld r15,PACA_EXGEN+EX_R15(r13) >> bl do_page_fault >> - cmpdi r3,0 >> - bne- 1f >> - b interrupt_return >> - mr r4,r3 >> - addi r3,r1,STACK_FRAME_OVERHEAD >> - bl __bad_page_fault > > Then __bad_page_fault() can be static now.
Good point, I'll change it. Thanks, Nick