Re: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE

[Christophe Leroy]

Le 29/03/2021 à 03:35, Tan, Ley Foon a écrit :

-----Original Message-----
From: Christophe Leroy <christophe.le...@csgroup.eu>
Sent: Friday, March 26, 2021 9:45 PM
To: w...@kernel.org; danie...@cisco.com; r...@kernel.org;
dan...@gimpelevich.san-francisco.ca.us
Cc: linux-a...@vger.kernel.org; devicet...@vger.kernel.org; linuxppc-
d...@lists.ozlabs.org; linux-ker...@vger.kernel.org; linuxppc-
d...@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; microblaze
<mon...@monstr.eu>; linux-m...@vger.kernel.org; Tan, Ley Foon
<ley.foon....@intel.com>; openr...@lists.librecores.org; linux-
hexa...@vger.kernel.org; linux-ri...@lists.infradead.org; x...@kernel.org;
linux-xte...@linux-xtensa.org; linux...@vger.kernel.org;
sparcli...@vger.kernel.org
Subject: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE

This converts the architecture to GENERIC_CMDLINE.

Signed-off-by: Christophe Leroy <christophe.le...@csgroup.eu>
---
  arch/nios2/Kconfig        | 24 +-----------------------
  arch/nios2/kernel/setup.c | 13 ++++---------
  2 files changed, 5 insertions(+), 32 deletions(-)

diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index
c24955c81c92..f66c97b15813 100644
--- a/arch/nios2/Kconfig
+++ b/arch/nios2/Kconfig
@@ -90,31 +90,9 @@ config NIOS2_ALIGNMENT_TRAP

  comment "Boot options"

-config CMDLINE_BOOL
-       bool "Default bootloader kernel arguments"
-       default y
-
-config CMDLINE
-       string "Default kernel command string"
-       default ""
-       depends on CMDLINE_BOOL
-       help
-         On some platforms, there is currently no way for the boot loader to
-         pass arguments to the kernel. For these platforms, you can supply
-         some command-line options at build time by entering them here.  In
-         other cases you can specify kernel args so that you don't have
-         to set them up in board prom initialization routines.
-
-config CMDLINE_FORCE
-       bool "Force default kernel command string"
-       depends on CMDLINE_BOOL
-       help
-         Set this to have arguments from the default kernel command string
-         override those passed by the boot loader.
-
  config NIOS2_CMDLINE_IGNORE_DTB
        bool "Ignore kernel command string from DTB"
-       depends on CMDLINE_BOOL
+       depends on CMDLINE != ""
        depends on !CMDLINE_FORCE
        default y
        help

Missing " select GENERIC_CMDLINE" ?

Added in v4

Thanks
Christophe