On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote:
Kumar Gala wrote:
On Jun 1, 2008, at 9:03 PM, David Gibson wrote:
On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote:
This patch adds support for the TQM8548 modules from TQ-Components
GmbH (http://www.tqc.de).
[snip]
index 0000000..d09250a
--- /dev/null
+++ b/arch/powerpc/boot/dts/tqm8548.dts
@@ -0,0 +1,370 @@
+/*
+ * TQM8548 Device Tree Source
+ *
+ * Copyright 2006 Freescale Semiconductor Inc.
+ * Copyright 2008 Wolfgang Grandegger <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or
modify it
+ * under the terms of the GNU General Public License as
published
by the
+ * Free Software Foundation; either version 2 of the License, or
(at your
+ * option) any later version.
+ */
+
+/dts-v1/;
[snip]
+ [EMAIL PROTECTED] {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cell-index = <0>;
[...]
+ enet0: [EMAIL PROTECTED] {
+ cell-index = <0>;
[...]
+ serial0: [EMAIL PROTECTED] {
+ cell-index = <0>;
[...]
+ pci0: [EMAIL PROTECTED] {
+ cell-index = <0>;
You have a whole lot of 'cell-index' properties through both these
trees, and they all look wrong. cell-index is a hack, which
should be
avoided wherever practical - it should only be used when the index
is
used to offset into some global register block, never simply to
differentiate (use reg for that) or name the devices (use aliases
for
that).
this is why FSL device tree's have cell-index. We have global
control
registers that need to know such things.
Should I remove them or not? OF is still a mystery for me :-(.
Don't remove them.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
