Hi Joe, [...] > > if (entry) > > - return sprintf(buf, "%s\n", > > - entry->msi_attrib.is_msix ? "msix" : "msi"); > > + return sysfs_emit(buf, "%s\n", > > + entry->msi_attrib.is_msix ? "msix" : "msi"); > > > > > > return -ENODEV; > > } > > trivia: reversing the test would be more common style > > if (!entry) > return -ENODEV; > > return sysfs_emit(...); > }
Excellent point. I will send v3 later that includes this style change. Thank you! Krzysztof
