* Michael Ellerman <m...@ellerman.id.au> [2021-08-25 23:01:42]: > Srikar Dronamraju <sri...@linux.vnet.ibm.com> writes: > > * Laurent Dufour <lduf...@linux.ibm.com> [2021-08-23 11:21:33]: > >> Le 21/08/2021 à 12:25, Srikar Dronamraju a écrit : > >> > Currently, a debug message gets printed every time an attempt to > >> > add(remove) a CPU. However this is redundant if the CPU is already added > >> > (removed) from the node. > >> > > > > > Its a fair point. > > > > Michael, > > > > Do you want me to resend this patch with s/pr_err/pr_warn for the above > > line? > > I think what I'd prefer is if we stopped using this custom dbg() stuff > in numa.c, and cleaned up all the messages to use pr_xxx(). > > Those debug statements only appear if you boot with numa=debug, which is > not documented anywhere and I had completely forgotten existed TBH. > > These days there's CONFIG_DYNAMIC_DEBUG for turning on/off messages, > which is much more flexible. > > So can we drop the numa=debug bits, and convert all the dbg()s to > pr_debug(). > > And then do a pass converting all the printk("NUMA: ") to pr_xxx() which > will get "numa:" from pr_fmt(). > > cheers
Okay, will do the needful. -- Thanks and Regards Srikar Dronamraju