Le 11/09/2021 à 01:40, Nick Desaulniers a écrit :
Now that GCC 5.1 is the minimum supported version, we can drop this
workaround for older versions of GCC. This adversely affected clang,
too.

Why do you say that GCC 5.1 is the minimum supported ?

As far as I can see, the minimum supported is still 4.9, see https://github.com/torvalds/linux/blob/master/Documentation/process/changes.rst


Cc: Michael Ellerman <m...@ellerman.id.au>
Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
Cc: Paul Mackerras <pau...@samba.org>
Cc: Segher Boessenkool <seg...@kernel.crashing.org>
Cc: Christophe Leroy <christophe.le...@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Nick Desaulniers <ndesaulni...@google.com>
---
  arch/powerpc/include/asm/asm-const.h | 10 ----------
  1 file changed, 10 deletions(-)

diff --git a/arch/powerpc/include/asm/asm-const.h 
b/arch/powerpc/include/asm/asm-const.h
index 0ce2368bd20f..dbfa5e1e3198 100644
--- a/arch/powerpc/include/asm/asm-const.h
+++ b/arch/powerpc/include/asm/asm-const.h
@@ -12,16 +12,6 @@
  #  define ASM_CONST(x)                __ASM_CONST(x)
  #endif
-/*
- * Inline assembly memory constraint
- *
- * GCC 4.9 doesn't properly handle pre update memory constraint "m<>"
- *
- */
-#if defined(GCC_VERSION) && GCC_VERSION < 50000
-#define UPD_CONSTR ""
-#else
  #define UPD_CONSTR "<>"
-#endif

There is no point in keeping UPD_CONSTR if it becomes invariant. You should just replace all instances of UPD_CONSTR with <> and drop UPD_CONSTR completely.

Christophe

Reply via email to