On Jun 17, 2008, at 11:11 AM, Nate Case wrote:
This adds support for hardware configurations that don't match the
chip default register settings (e.g., 16-bit data bus, DACK and
DREQ pulled up instead of down, analog overcurrent mode).
These settings are passed in via the OF device tree. The PCI
interface still assumes the same default values.
Signed-off-by: Nate Case <[EMAIL PROTECTED]>
---
This version addresses feedback from Sebastian Siewior and
Olof Johansson. Specifically, a new flag was added for ISP1761 which
is set during probe time. This is used instead of checking the Chip
ID register (which doesn't allow you to distinguish between the
ISP1760
and ISP1761). Also, device tree property checking is adjusted to
simply check for a property's presence when setting flags.
I tested this version on both a custom ppc64 board and Electra.
Olof also tried testing it on his Electra but without success (I'm
guessing, perhaps naively, that a difference between our setups was
the cause and the driver changes are still OK).
Yeah, I'm not 100% sure that it's not broken hardware here. Even if it
turns out not to be what's wrong, the rest of the patch seems good to
me. I.e. good enough to merge even if it'll take a fix to iron out the
last stuff down the road.
Acked-by: Olof Johansson <[EMAIL PROTECTED]>
-Olof
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
