Hi-- On 4/10/22 00:03, Christophe Leroy wrote: > > > Le 09/04/2022 à 04:08, Randy Dunlap a écrit : >> Fix build when RTC_CLASS is not set/enabled. >> Eliminates these build errors: >> >> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time': >> drivers/macintosh/via-pmu.c:1769: undefined reference to `rtc_tm_to_time64' >> m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time': >> drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64' > > You don't need RTC_CLASS for that. All you need is RTC_LIB I think.
Oh good. > What about selecting RTC_LIB from m68k Kconfig just like powerpc and a > few architectures do ? Sounds good. I'll test that now. > See > https://elixir.bootlin.com/linux/v5.18-rc1/source/arch/powerpc/Kconfig#L269 > > Otherwise, I think it would be better to move (and rename) > rtc_tm_to_time64() into kernel/time/time.c instead of opencoding it twice. > Yeah, I didn't like that either. >> >> Fixes: 0792a2c8e0bb ("macintosh: Use common code to access RTC") >> Signed-off-by: Randy Dunlap <rdun...@infradead.org> >> Reported-by: kernel test robot <l...@intel.com> >> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> >> Cc: Michael Ellerman <m...@ellerman.id.au> >> Cc: Christophe Leroy <christophe.le...@csgroup.eu> >> Cc: Kees Cook <keesc...@chromium.org> >> Cc: Arnd Bergmann <a...@arndb.de> >> Cc: Finn Thain <fth...@linux-m68k.org> >> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> >> Cc: Nathan Chancellor <nat...@kernel.org> >> Cc: Nick Desaulniers <ndesaulni...@google.com> >> Cc: linuxppc-dev@lists.ozlabs.org >> --- >> drivers/macintosh/via-cuda.c | 5 ++++- >> drivers/macintosh/via-pmu.c | 5 ++++- >> 2 files changed, 8 insertions(+), 2 deletions(-) thanks. -- ~Randy
