On Tue, Jun 24, 2008 at 3:24 PM, John Rigby <[EMAIL PROTECTED]> wrote:
> Move shared code from mpc5121_ads.c to mpc512x_shared.c.
> Add new generic board setup mpc5121_generic.c
>
> Signed-off-by: John Rigby <[EMAIL PROTECTED]>
> ---
> +void __init mpc512x_init_IRQ(void)
> +{
> + struct device_node *np;
> +
> + np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
Along with all my other device-tree conventions comments; you should
really be testing for fsl,mpc5121-ipic here. fsl,ipic is not a good
value for compatible.
g.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
