On Wed, Sep 07, 2022 at 09:23:02AM +1000, Michael Ellerman wrote: > Nathan Chancellor <nat...@kernel.org> writes: > > Hi all, > > > > On Sat, Jul 23, 2022 at 07:30:46AM -0400, Nayna Jain wrote: > >> PowerVM provides an isolated Platform Keystore(PKS) storage allocation > >> for each LPAR with individually managed access controls to store > >> sensitive information securely. It provides a new set of hypervisor > >> calls for Linux kernel to access PKS storage. > >> > >> Define POWER LPAR Platform KeyStore(PLPKS) driver using H_CALL interface > >> to access PKS storage. > >> > >> Signed-off-by: Nayna Jain <na...@linux.ibm.com> > > > > This commit is now in mainline as commit 2454a7af0f2a ("powerpc/pseries: > > define driver for Platform KeyStore") and I just bisected a crash while > > boot testing Fedora's configuration [1] in QEMU to it. I initially > > noticed this in ClangBuiltLinux's CI but this doesn't appear to be clang > > specific since I can reproduce with GCC 12.2.1 from Fedora. I can > > reproduce with just powernv_defconfig + CONFIG_PPC_PSERIES=y + > > CONFIG_PSERIES_PLPKS=y. Our firmware and rootfs are available in our > > boot-utils repository [2]. > > Thanks, classic bug I should have spotted. > > I didn't catch it in my testing because PLPKS isn't enabled in > our defconfigs. > > Does your CI enable new options by default? Or are you booting > allyesconfig?
Neither actually. We just test a bunch of in-tree and distribution configurations. The distribution configurations are fetched straight from their URLs on gitweb so we get any updates that they do, which is how we noticed this (CONFIG_PSERIES_PLPKS was recently enabled in Fedora): https://src.fedoraproject.org/rpms/kernel/c/a73f6858a2cbd16bbcc6d305d6c43aab6f59d0b1 > I'll send a fix. Thanks for the quick response! Cheers, Nathan