On Tue, Jan 3, 2023 at 10:45 AM Geoff Levand <ge...@infradead.org> wrote: > > Hi Rob, > > On 1/2/23 18:03, Rob Herring wrote: > > On Mon, Jan 2, 2023 at 1:41 PM Geoff Levand <ge...@infradead.org> wrote: > > >> --- a/arch/powerpc/kernel/prom.c > >> +++ b/arch/powerpc/kernel/prom.c > >> @@ -761,7 +761,7 @@ void __init early_init_devtree(void *params) > >> DBG(" -> early_init_devtree(%px)\n", params); > >> > >> /* Too early to BUG_ON(), do it by hand */ > >> - if (!early_init_dt_verify(params)) > >> + if (!early_init_dt_scan(params)) > > > > It would be nice if this could be used instead, but it does other > > things like memory setup which I think will not work for some PPC > > platforms. > > It seems like what we need is to pull out the command line processing > code from early_init_dt_scan_nodes and put that into a new function, > say early_init_setup_cmdline, then have both early_init_dt_scan_nodes > and powerpc's early_init_devtree call early_init_setup_cmdline. > > I'll split this series into two, one for the PS3 updates, and one > that adds early_init_setup_cmdline.
What is really needed is to make progress on the generic command line handling, but the 2 different implementations can't seem to work together to resolve the differences. Short of that, I don't really want to see another function exposed to the arch as I've been trying to reduce them. I'll post an alternative shortly. Rob