Re: [PATCH] powerpc/kexec_file: print error string on usable memory property update failure

[Sourabh Jain]

The only place on kexec/kdump path where we don't print
reason for FDT operation failure. This patch fix that.

Will this be a good candidate for next rc?

Thanks,
Sourabh

On 16/12/22 17:57, Sourabh Jain wrote:

Print the FDT error description along with the error message if failed
to set the "linux,drconf-usable-memory" property in the kdump kernel's
FDT.

Signed-off-by: Sourabh Jain <sourabhj...@linux.ibm.com>
---
  arch/powerpc/kexec/file_load_64.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/file_load_64.c 
b/arch/powerpc/kexec/file_load_64.c
index 349a781cea0b3..7602f7e1e634e 100644
--- a/arch/powerpc/kexec/file_load_64.c
+++ b/arch/powerpc/kexec/file_load_64.c
@@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct 
crash_mem *usable_mem)
                ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory",
                                  um_info.buf, (um_info.idx * sizeof(u64)));
                if (ret) {
-                       pr_err("Failed to update fdt with linux,drconf-usable-memory 
property");
+                       pr_err("Failed to update fdt with linux,drconf-usable-memory 
property: %s",
+                              fdt_strerror(ret));
                        goto out;
                }
        }