> -----Original Message----- > From: Sean Anderson <sean.ander...@seco.com> > Sent: Friday, March 31, 2023 18:14 > To: Leo Li <leoyang...@nxp.com>; linuxppc-dev@lists.ozlabs.org; linux-arm- > ker...@lists.infradead.org > Cc: Scott Wood <o...@buserror.net>; Camelia Alexandra Groza > <camelia.gr...@nxp.com>; linux-ker...@vger.kernel.org; Roy Pledge > <roy.ple...@nxp.com>; David S . Miller <da...@davemloft.net>; Claudiu > Manoil <claudiu.man...@nxp.com>; Vladimir Oltean > <vladimir.olt...@nxp.com>; Sean Anderson <sean.ander...@seco.com> > Subject: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock > > cgr_lock may be locked with interrupts already disabled by > smp_call_function_single. As such, we must use a raw spinlock to avoid > problems on PREEMPT_RT kernels. Although this bug has existed for a > while, it was not apparent until commit ef2a8d5478b9 ("net: dpaa: Adjust > queue depth on rate change") which invokes smp_call_function_single via > qman_update_cgr_safe every time a link goes up or down. > > Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver") > Reported-by: Vladimir Oltean <vladimir.olt...@nxp.com> > Link: https://lore.kernel.org/all/20230323153935.nofnjucqjqnz34ej@skbuf/ > Signed-off-by: Sean Anderson <sean.ander...@seco.com>
Reviewed-by: Camelia Groza <camelia.gr...@nxp.com>