Hi Mark, Liam,
On 5/30/23 16:38, Randy Dunlap wrote:
> Hello maintainers,
>
> I am still seeing these build errors on linux-next-20230530.
>
> Is there a problem with the patch?
> Thanks.
>
I am still seeing build errors on linux-next-20230615.
Is there a problem with the patch?
Can it be applied/merged?
Thanks.
> On 5/21/23 15:57, Randy Dunlap wrote:
>> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
>> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
>> so the 2 former symbols should also depend on PPC_BESTCOMM since
>> "select" does not follow any dependency chains.
>>
>> This prevents a kconfig warning and build errors:
>>
>> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
>> Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] &&
>> SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
>> Selected by [m]:
>> - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC
>> [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
>> - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC
>> [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
>>
>> ERROR: modpost: "mpc5200_audio_dma_destroy"
>> [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>> ERROR: modpost: "mpc5200_audio_dma_create"
>> [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>>
>> Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric
>> drivers")
>> Signed-off-by: Randy Dunlap <rdun...@infradead.org>
>> Cc: Grant Likely <grant.lik...@secretlab.ca>
>> Cc: Mark Brown <broo...@kernel.org>
>> Cc: Liam Girdwood <lgirdw...@gmail.com>
>> Cc: Shengjiu Wang <shengjiu.w...@gmail.com>
>> Cc: Xiubo Li <xiubo....@gmail.com>
>> Cc: alsa-de...@alsa-project.org
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: Jaroslav Kysela <pe...@perex.cz>
>> Cc: Takashi Iwai <ti...@suse.com>
>> ---
>> v2: use correct email address for Mark Brown.
>>
>> sound/soc/fsl/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
>> --- a/sound/soc/fsl/Kconfig
>> +++ b/sound/soc/fsl/Kconfig
>> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
>>
>> config SND_MPC52xx_SOC_PCM030
>> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
>> - depends on PPC_MPC5200_SIMPLE
>> + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
>> select SND_SOC_MPC5200_AC97
>> select SND_SOC_WM9712
>> help
>> @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
>>
>> config SND_MPC52xx_SOC_EFIKA
>> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
>> - depends on PPC_EFIKA
>> + depends on PPC_EFIKA && PPC_BESTCOMM
>> select SND_SOC_MPC5200_AC97
>> select SND_SOC_STAC9766
>> help
>
--
~Randy
