password might contain private information, so better use
kfree_sensitive to free it.
In plpks_gen_password() use kfree_sensitive().

Signed-off-by: Minjie Du <dumin...@vivo.com>
---
 arch/powerpc/platforms/pseries/plpks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/plpks.c 
b/arch/powerpc/platforms/pseries/plpks.c
index b0658ea3e..3441e616e 100644
--- a/arch/powerpc/platforms/pseries/plpks.c
+++ b/arch/powerpc/platforms/pseries/plpks.c
@@ -150,7 +150,7 @@ static int plpks_gen_password(void)
                ospasswordlength = maxpwsize;
                ospassword = kzalloc(maxpwsize, GFP_KERNEL);
                if (!ospassword) {
-                       kfree(password);
+                       kfree_sensitive(password);
                        return -ENOMEM;
                }
                memcpy(ospassword, password, ospasswordlength);
@@ -163,7 +163,7 @@ static int plpks_gen_password(void)
                }
        }
 out:
-       kfree(password);
+       kfree_sensitive(password);
 
        return pseries_status_to_err(rc);
 }
-- 
2.39.0

Reply via email to