On Mon, 25 Sep 2023 11:54:57 +0200
Uwe Kleine-König <u.kleine-koe...@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
> ---
> drivers/soc/fsl/qe/qmc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index b3c292c9a14e..92ec76c03965 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -1415,7 +1415,7 @@ static int qmc_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int qmc_remove(struct platform_device *pdev)
> +static void qmc_remove(struct platform_device *pdev)
> {
> struct qmc *qmc = platform_get_drvdata(pdev);
>
> @@ -1427,8 +1427,6 @@ static int qmc_remove(struct platform_device *pdev)
>
> /* Disconnect the serial from TSA */
> tsa_serial_disconnect(qmc->tsa_serial);
> -
> - return 0;
> }
>
> static const struct of_device_id qmc_id_table[] = {
> @@ -1443,7 +1441,7 @@ static struct platform_driver qmc_driver = {
> .of_match_table = of_match_ptr(qmc_id_table),
> },
> .probe = qmc_probe,
> - .remove = qmc_remove,
> + .remove_new = qmc_remove,
> };
> module_platform_driver(qmc_driver);
>
Acked-by: Herve Codina <herve.cod...@bootlin.com>
Best regards,
Hervé
