Re: [PATCH 3/3] tools/perf/tests: Fix shellcheck warning in record_sideband.sh test

[Athira Rajeev]

> On 05-Oct-2023, at 10:34 AM, Namhyung Kim <namhy...@kernel.org> wrote:
> 
> On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev
> <atraj...@linux.vnet.ibm.com> wrote:
>> 
>> Running shellcheck on record_sideband.sh throws below
>> warning:
>> 
>>        In tests/shell/record_sideband.sh line 25:
>>          if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 
>> >/dev/null
>>            ^--^ SC2069: To redirect stdout+stderr, 2>&1 must be last (or use 
>> '{ cmd > file; } 2>&1' to clarify).
>> 
>> This shows shellcheck warning SC2069 where the redirection
>> order needs to be fixed. Use { cmd > file; } 2>&1 to fix the
>> redirection of perf record output
>> 
>> Fixes: 23b97c7ee963 ("perf test: Add test case for record sideband events")
>> Signed-off-by: Athira Rajeev <atraj...@linux.vnet.ibm.com>
>> ---
>> tools/perf/tests/shell/record_sideband.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tools/perf/tests/shell/record_sideband.sh 
>> b/tools/perf/tests/shell/record_sideband.sh
>> index 5024a7ce0c51..7e036763a43c 100755
>> --- a/tools/perf/tests/shell/record_sideband.sh
>> +++ b/tools/perf/tests/shell/record_sideband.sh
>> @@ -22,7 +22,7 @@ trap trap_cleanup EXIT TERM INT
>> 
>> can_cpu_wide()
>> {
>> -    if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 
>> >/dev/null
>> +    if ! { perf record -o ${perfdata} -BN --no-bpf-event -C $1 true > 
>> /dev/null; } 2>&1
> 
> I think we usually go without braces.

Hi Namhyung

Thanks for reviving.I will fix this in V2

Thanks
Athira
> 
> Thanks,
> Namhyung
> 
> 
>>     then
>>         echo "record sideband test [Skipped cannot record cpu$1]"
>>         err=2
>> --
>> 2.31.1