Running shellcheck on record_sideband.sh throws below
warning:
In tests/shell/record_sideband.sh line 25:
if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1
>/dev/null
^--^ SC2069: To redirect stdout+stderr, 2>&1 must be last (or use
'{ cmd > file; } 2>&1' to clarify).
This shows shellcheck warning SC2069 where the redirection
order needs to be fixed. Use "cmd > /dev/null 2>&1" to fix
the redirection of perf record output
Fixes: 23b97c7ee963 ("perf test: Add test case for record sideband events")
Signed-off-by: Athira Rajeev <atraj...@linux.vnet.ibm.com>
Reviewed-by: Kajol Jain <kj...@linux.ibm.com>
---
changelog:
v1 -> v2:
Add Reviewed-by from Kajol
Used "cmd > /dev/null 2>&1" to fix the redirection
warning from shellcheck
tools/perf/tests/shell/record_sideband.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/record_sideband.sh
b/tools/perf/tests/shell/record_sideband.sh
index 5024a7ce0c51..ac70ac27d590 100755
--- a/tools/perf/tests/shell/record_sideband.sh
+++ b/tools/perf/tests/shell/record_sideband.sh
@@ -22,7 +22,7 @@ trap trap_cleanup EXIT TERM INT
can_cpu_wide()
{
- if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1
>/dev/null
+ if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true > /dev/null
2>&1
then
echo "record sideband test [Skipped cannot record cpu$1]"
err=2
--
2.31.1
