On Fri, Nov 24, 2023 at 2:08 PM Christophe Leroy <christophe.le...@csgroup.eu> wrote: > > > > Le 24/11/2023 à 11:02, Dario Binacchi a écrit : > > s/singals/signals/ > > Is that really worth it to spend time on such a change ? > > By sending such a patch, you require people to spend time reviewing your > patch, then maintainer has to spend time handling your patch. > Furthermore, as you added a Fixes: tag, LTS maintainers will have to > spend time handling that too. > > Do you really think that this typo is worth a patch ? > > This kind of tiny error should be fixed through a more significant patch > adressing this file. But it is not worth a patch on its own.
It's not the first time I've submitted patches of this kind, and no one has ever complained before. However, if it has become an issue, I won't do it anymore. Thanks and regards, Dario > > Christophe > > > > > > Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb") > > Signed-off-by: Dario Binacchi <dario.binac...@amarulasolutions.com> > > --- > > > > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c > > b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c > > index ec9f60fbebc7..e0cec670d8db 100644 > > --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c > > +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c > > @@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void) > > /* P1025 has pins muxed for QE and other functions. To > > * enable QE UEC mode, we need to set bit QE0 for UCC1 > > * in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9 > > - * and QE12 for QE MII management singals in PMUXCR > > + * and QE12 for QE MII management signals in PMUXCR > > * register. > > */ > > setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) > > | -- Dario Binacchi Senior Embedded Linux Developer dario.binac...@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 i...@amarulasolutions.com www.amarulasolutions.com