Hi, Le 24/01/2024 à 09:41, sambat goson a écrit : > > Hi, > I've just test it and find below code not proper in function > "gelic_descr_prepare_rx", line 398. > it causes error as my attached file. > > descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size); > if (!descr->skb) { > descr->hw_regs.payload.dev_addr = 0; /* tell DMAC don't touch memory */ > return -ENOMEM; > } > descr->hw_regs.dmac_cmd_status = 0; > descr->hw_regs.result_size = 0; > descr->hw_regs.valid_size = 0; > descr->hw_regs.data_error = 0; > descr->hw_regs.payload.dev_addr = 0; > descr->hw_regs.payload.size = 0; > descr->skb = NULL; ---->line 398 >
Looks like a copy/paste error from gelic_descr_release_tx() in commit 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures"), the whole block is wrong I guess, not only the descr->skb = NULL; Geoff, can you fix it ? Christophe