configure will accept an unknown arch, and if it is the name of a directory in the source tree the command will silently succeed. Make it only accept supported arch names.
Also print the full path of a missing test directory to disambiguate the error in out of tree builds. Cc: Alexandru Elisei <alexandru.eli...@arm.com> Cc: Andrew Jones <andrew.jo...@linux.dev> Cc: Claudio Imbrenda <imbre...@linux.ibm.com> Cc: David Hildenbrand <da...@redhat.com> Cc: Eric Auger <eric.au...@redhat.com> Cc: Janosch Frank <fran...@linux.ibm.com> Cc: Laurent Vivier <lviv...@redhat.com> Cc: Nico Böhr <n...@linux.ibm.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: Thomas Huth <th...@redhat.com> Cc: k...@vger.kernel.org Cc: linux-s...@vger.kernel.org Cc: kvm...@lists.linux.dev Cc: kvm-ri...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Nicholas Piggin <npig...@gmail.com> --- configure | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 6907ccbbb..ae522c556 100755 --- a/configure +++ b/configure @@ -45,7 +45,8 @@ usage() { Usage: $0 [options] Options include: - --arch=ARCH architecture to compile for ($arch) + --arch=ARCH architecture to compile for ($arch). ARCH can be one of: + arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 --processor=PROCESSOR processor to compile for ($arch) --target=TARGET target platform that the tests will be running on (qemu or kvmtool, default is qemu) (arm/arm64 only) @@ -321,11 +322,15 @@ elif [ "$arch" = "ppc64" ]; then elif [ "$arch" = "riscv32" ] || [ "$arch" = "riscv64" ]; then testdir=riscv arch_libdir=riscv +elif [ "$arch" = "s390x" ]; then + testdir=s390x else - testdir=$arch + echo "arch $arch is not supported!" + arch= + usage fi if [ ! -d "$srcdir/$testdir" ]; then - echo "$testdir does not exist!" + echo "$srcdir/$testdir does not exist!" exit 1 fi -- 2.42.0