On Friday 15 August 2008, Sean MacLennan wrote:
> Port the ndfc driver to an OF platform driver.
> 
> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>

Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>

Looks great, but I just noticed one more detail:

> +static const struct of_device_id ndfc_match[] = {
> +     { .compatible = "amcc,ndfc", },
> +     {}
>  };
>  

You should add

MODULE_DEVICE_TABLE(of, &ndfc_match);

to enable module auto-loading.

        Arnd <><
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to