On Tue, Oct 01, 2024 at 02:08:18PM +0200, Christophe Leroy wrote: > > > Le 01/10/2024 à 12:08, Michal Suchanek a écrit : > > There is no modular user of analyze_instr, and the latter two are only > > used by sstep itself. > > analyze_instr() is used in arch/powerpc/kvm/emulate_loadstore.c which can be > a module as far as I can see in Makefile: > > common-objs-y += powerpc.o emulate_loadstore.o > > kvm-book3s_64-module-objs := \ > $(common-objs-y) \ > book3s.o \ > book3s_rtas.o \ > $(kvm-book3s_64-objs-y) > > kvm-objs-$(CONFIG_KVM_BOOK3S_64) := $(kvm-book3s_64-module-objs) > > config KVM_BOOK3S_64 > tristate "KVM support for PowerPC book3s_64 processors"
Indeed, missed that it can be modular thruogh this indirection. Thanks Michal > > > > > > Signed-off-by: Michal Suchanek <msucha...@suse.de> > > --- > > arch/powerpc/lib/sstep.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c > > index e65f3fb68d06..a0557b0d9a24 100644 > > --- a/arch/powerpc/lib/sstep.c > > +++ b/arch/powerpc/lib/sstep.c > > @@ -863,7 +863,6 @@ void emulate_vsx_load(struct instruction_op *op, union > > vsx_reg *reg, > > break; > > } > > } > > -EXPORT_SYMBOL_GPL(emulate_vsx_load); > > NOKPROBE_SYMBOL(emulate_vsx_load); > > void emulate_vsx_store(struct instruction_op *op, const union vsx_reg > > *reg, > > @@ -955,7 +954,6 @@ void emulate_vsx_store(struct instruction_op *op, const > > union vsx_reg *reg, > > break; > > } > > } > > -EXPORT_SYMBOL_GPL(emulate_vsx_store); > > NOKPROBE_SYMBOL(emulate_vsx_store); > > static nokprobe_inline int do_vsx_load(struct instruction_op *op, > > @@ -3172,7 +3170,6 @@ int analyse_instr(struct instruction_op *op, const > > struct pt_regs *regs, > > op->val = SRR1_PROGTRAP; > > return 0; > > } > > -EXPORT_SYMBOL_GPL(analyse_instr); > > NOKPROBE_SYMBOL(analyse_instr); > > /*
